Skip to content

Batch transactions - Add support #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Batch transactions - Add support #621

wants to merge 8 commits into from
+104 −1

Conversation

pandablue0809
Copy link
Member

Issue

Add support of batch txs
Now, I display the main datas.
If you share your specific requirements, I’ll take care of the implementation.

@pandablue0809 pandablue0809 requested a review from ihomp September 19, 2025 22:00
@ihomp
Copy link
Member

ihomp commented Oct 12, 2025

We need to show all transactions data that is in the batch.

@Anna15170221 can you take a look?

please share transactions links that are used for tests

@Anna15170221
Copy link
Contributor

@ihomp new examples provided by Ildar
http://localhost:3000/en/tx/DED0B7C7446D6A1025573BD7C146B52052A5E2475A5C2E9CD885E415F658D699
http://localhost:3000/en/tx/7A8C234309827A8571B234816B6E843B2954BE4FDA92DA4562E9E657A342D216
http://localhost:3000/en/tx/6EBFE19875BB7B8721D1AD707B0E91BAE2E166AE3E51D363472078F5F28B6724
http://localhost:3000/en/tx/A771F0CCF98839E46843A0B6E9F46D0B0AFF392B85A079A4F91B157B5F9F0DF6
@pandablue0809 as Slava mentioned we need to show all transactions data that is in the batch. So if it's payment, show all payment details.
I am not sure about the flags. We need to check this.
I can see that allOrNothing falg is enabled here A771F0CCF98839E46843A0B6E9F46D0B0AFF392B85A079A4F91B157B5F9F0DF6 but we don't show it in your current version.

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it.
plz review again. 🙏

@ihomp
Copy link
Member

ihomp commented Oct 15, 2025

@Anna15170221 please review again

@Anna15170221
Copy link
Contributor

@ihomp
should we probably show fiat amounts also in details?

@ihomp
Copy link
Member

ihomp commented Oct 15, 2025

@ihomp should we probably show fiat amounts also in details?

Yes, but I think it will only be visible in production (mainnet/staging) - we can test with "staging" instead of "devnet" - than it should show.

ihomp
ihomp reviewed Oct 20, 2025
View reviewed changes
components/Transaction/TransactionBatch.js Outdated
import Link from 'next/link'

// Component to display transaction flags with tooltips
const TransactionFlags = ({ flags }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the functionn in utils showFlags - please reuse it

ihomp
ihomp requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts and reuse showFlags from utils

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it.
plz review again. 🙏

@pandablue0809 pandablue0809 requested a review from ihomp October 21, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihomp ihomp Awaiting requested review from ihomp

Assignees

No one assigned

Labels

Priority 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pandablue0809 @ihomp @Anna15170221